Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_block_data: use data_size for static volumes #100

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

yousong
Copy link
Contributor

@yousong yousong commented Dec 12, 2024

To avoid ubireader_extract_images also extracting 0xff bytes at the end of LEB

@yousong
Copy link
Contributor Author

yousong commented Dec 12, 2024

@AT0myks
Copy link
Contributor

AT0myks commented Dec 12, 2024

This might also be of interest: https://github.com/torvalds/linux/blob/231825b2e1ff6ba799c5eaf396d3ab2354e37c6b/drivers/mtd/ubi/eba.c#L1322-L1327

@qkaiser qkaiser self-requested a review February 10, 2025 13:40
To avoid ubireader_extract_images also extracting 0xff bytes at the end
of LEB
@qkaiser qkaiser force-pushed the yousong-use-data_size branch from 4c41af9 to 40f6f59 Compare February 10, 2025 13:40
@qkaiser
Copy link
Contributor

qkaiser commented Feb 10, 2025

Sorry it took us so long, thanks for the contribution @yousong !

@qkaiser qkaiser merged commit 2fdeae0 into onekey-sec:main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants